Improve date/time parsing #834
Merged
+73
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
force-pushed
the
improve-date-parse
branch
from
226c1c0
to
f420e96
Compare
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
==========================================
+ Coverage 91.09% 91.12% +0.02%
==========================================
Files 23 23
Lines 4123 4136 +13
==========================================
+ Hits 3756 3769 +13
Misses 367 367
Continue to review full report at Codecov.
|
Refs python-babel#442 Co-authored-by: David Bauer <david.bauer009@gmail.com> Co-authored-by: Arthur Jovart <arthur@jovart.com>
``parse_date()`` does not allow the user to specify the date's format and the 'medium' format is used by default in the call to ``get_date_format()`` on line 1144. This results in a failure to parse the date in short format for the locale 'sv_SE'. This commit adds the format argument to avoid this failure. The default value is set to 'medium' to preserve the old behavior. Fixes python-babel#657 Co-authored-by: Aarni Koskela <akx@iki.fi>
akx
force-pushed
the
improve-date-parse
branch
from
d9246f4
to
8a5e4bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #442
Fixes #657
Closes #448 (supersedes it)
Closes #767 (supersedes it)
Closes #659 (supersedes it)