Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow header_comment to be passed as an option to extract_message #720

Merged
merged 2 commits into from Apr 12, 2022

Conversation

muhamed-hafez
Copy link
Contributor

This fixes #82

babel/messages/frontend.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #720 (6630139) into master (20352cc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   91.33%   91.34%           
=======================================
  Files          23       23           
  Lines        4191     4192    +1     
=======================================
+ Hits         3828     3829    +1     
  Misses        363      363           
Impacted Files Coverage Δ
babel/messages/frontend.py 87.96% <100.00%> (+0.02%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of fixing the typo, and also fixing things so the default header is used by... well, default.

There's also a test case now.

@akx akx merged commit 61109c4 into python-babel:master Apr 12, 2022
m-aciek added a commit to m-aciek/babel that referenced this pull request Jan 29, 2023
akx pushed a commit that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow header_comment to be passed as an option to extract_message
2 participants