Copy project, version info when updating from template #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating catalogs using the 'update_catalog' command, one would expect to see the 'Project-Id-Version' header updated using the information extracted with distutils. Make it so. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Closes: python-babel#705
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
==========================================
+ Coverage 91.09% 91.12% +0.02%
==========================================
Files 23 23
Lines 4156 4158 +2
==========================================
+ Hits 3786 3789 +3
+ Misses 370 369 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Oh wow, I'd forgotten about this. It'd be great to land this but fair warning, I've totally forgotten the context on this by now (in my defense, it's been 2 COVID-ful years) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating catalogs using the 'update_catalog' command, one would expect to see the 'Project-Id-Version' header updated using the information extracted with distutils. Make it so.
Closes: #705