Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse string date times indepentent of time zone #701

Merged
merged 1 commit into from Jan 28, 2022
Merged

Parse string date times indepentent of time zone #701

merged 1 commit into from Jan 28, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 1, 2020

Parsing a date time string (such as for POT-Creation-Date or
PO-Revision-Date) as UTC time, in particular independent of the
local time zone.

Closes: #700

Parsing a date time string (such as for ``POT-Creation-Date`` or
``PO-Revision-Date``) as UTC time, in particular independent of the
local time zone.

Closes: #700
This was referenced Oct 5, 2020
@codecov-io
Copy link

Codecov Report

Merging #701 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
- Coverage   90.97%   90.96%   -0.01%     
==========================================
  Files          24       24              
  Lines        4176     4173       -3     
==========================================
- Hits         3799     3796       -3     
  Misses        377      377              
Impacted Files Coverage Δ
babel/messages/catalog.py 95.60% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cfa69e...5d23faa. Read the comment docs.

@ghost
Copy link
Author

ghost commented Oct 12, 2021

Any chance this would be merged?

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The docs say mktime is the inverse of localtime, and we're taking care of the timezone just after this, so a tz-naive parsing function is the right thing.

@akx akx merged commit 9d6803a into python-babel:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Times are parsed inconsistently with respect to local time when they should be UTC
2 participants