Ignore 'Language' header in PO-templates #666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinoroc
force-pushed
the
language-header-in-template
branch
from
e769fd2
to
d3a1b1c
Compare
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
+ Coverage 90.90% 90.97% +0.06%
==========================================
Files 25 24 -1
Lines 4356 4177 -179
==========================================
- Hits 3960 3800 -160
+ Misses 396 377 -19
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Anything I can do to get this moving? |
sinoroc
force-pushed
the
language-header-in-template
branch
from
d3a1b1c
to
05393ba
Compare
The tools 'xgettext' from GNU gettext and 'pot-create' from lingua both produce PO-template files containing a 'Language' header with an empty string as value. Babel has issues creating catalogs out of such templates. It wants to parse the PO-template as a normal PO-catalog using the locale of the target catalog, because it helps producing the correct plurals. But it overwrites this locale when parsing the 'Language' header and then it can not produce a valid catalog. Ignoring the 'Language' header when it is known that the file being processed is a template avoids this issue. GitHub: fixes python-babel#665
sinoroc
force-pushed
the
language-header-in-template
branch
from
05393ba
to
2e86b47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tools 'xgettext' from GNU gettext and 'pot-create' from lingua
both produce PO-template files containing a 'Language' header with
an empty string as value.
Babel has issues creating catalogs out of such templates.
It wants to parse the PO-template as a normal PO-catalog using the
locale of the target catalog, because it helps producing the correct
plurals. But it overwrites this locale when parsing the 'Language'
header and then it can not produce a valid catalog.
Ignoring the 'Language' header when it is known that the file being
processed is a template avoids this issue.
GitHub: fixes #665