feat: allow precision specification when bypassing decimal quantization #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1058 +/- ##
==========================================
- Coverage 90.99% 89.83% -1.17%
==========================================
Files 26 26
Lines 4444 4448 +4
==========================================
- Hits 4044 3996 -48
- Misses 400 452 +52 ☔ View full report in Codecov by Sentry. |
Olunusib
force-pushed
the
feat/decimal-quantization-precision
branch
from
48c2faa
to
cf0cf53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bypassing decimal quantization, we should be able to specify precision. Closes #893
Note: This PR is a recreation of the previously closed PR #1010. The original changes were lost due to issues with my previous machine setup. I have re-applied the changes as accurately as possible to maintain the continuity of the work and discussion from PR #1010.
cc @FelixSchwarz @clj @gdiscry