Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require cloudpickle for PyPy #892

Merged
merged 5 commits into from Dec 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["2.7", "3.5", "3.6", "3.7", "3.8", "3.9", "3.10", "pypy-2.7", "pypy-3.7"]
python-version: ["2.7", "3.5", "3.6", "3.7", "3.8", "3.9", "3.10", "pypy-2.7", "pypy-3.7", "pypy-3.8"]

steps:
- uses: actions/checkout@v2
Expand Down
1 change: 1 addition & 0 deletions changelog.d/892.change.rst
@@ -0,0 +1 @@
Fixed the test suite on PyPy3.8 where cloudpickle does not work.
2 changes: 1 addition & 1 deletion setup.py
Expand Up @@ -50,7 +50,7 @@
"docs": ["furo", "sphinx", "zope.interface", "sphinx-notfound-page"],
"tests_no_zope": [
# For regression test to ensure cloudpickle compat doesn't break.
"cloudpickle",
'cloudpickle; python_implementation == "CPython"',
# 5.0 introduced toml; parallel was broken until 5.0.2
"coverage[toml]>=5.0.2",
"hypothesis",
Expand Down
5 changes: 4 additions & 1 deletion tests/test_3rd_party.py
Expand Up @@ -4,13 +4,16 @@
Tests for compatibility against other Python modules.
"""

import cloudpickle
import pytest

from hypothesis import given

from .strategies import simple_classes


cloudpickle = pytest.importorskip("cloudpickle")


class TestCloudpickleCompat(object):
"""
Tests for compatibility with ``cloudpickle``.
Expand Down