Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NG: convert on setattr by default #886

Merged
merged 5 commits into from Dec 14, 2021
Merged

NG: convert on setattr by default #886

merged 5 commits into from Dec 14, 2021

Commits on Dec 13, 2021

  1. NG: convert on setattr by default 

    Not doing that from the get-go was an oversight.

Fixes #835
    @hynek
    hynek committed Dec 13, 2021
    Copy the full SHA
    fedc570 View commit details
    Browse the repository at this point in the history

  2. Add optimization for default on_setattr w/ no work to do 

    Otherwise we'd end up with an explicit setattr every time.
    @hynek
    hynek committed Dec 13, 2021
    Copy the full SHA
    7d4c184 View commit details
    Browse the repository at this point in the history

  3. Fix optimization for NG default & j/ convert

    @hynek
    hynek committed Dec 13, 2021
    Copy the full SHA
    f4ee131 View commit details
    Browse the repository at this point in the history

  4. NG is actually 3.6+

    @hynek
    hynek committed Dec 13, 2021
    Copy the full SHA
    5a927a0 View commit details
    Browse the repository at this point in the history

  5. Add test for convert optimization for good measure

    @hynek
    hynek committed Dec 13, 2021
    Copy the full SHA
    cb490f8 View commit details
    Browse the repository at this point in the history