Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reset custom __setattr__ in slotted classes #681

Merged
merged 11 commits into from Sep 5, 2020
Merged

Don't reset custom __setattr__ in slotted classes #681

merged 11 commits into from Sep 5, 2020

Commits on Sep 3, 2020

  1. Don't reset custom __setattr__ in slotted classes 

    Fixes #680

Signed-off-by: Hynek Schlawack <hs@ox.cx>
    @hynek
    hynek committed Sep 3, 2020
    Copy the full SHA
    a415d51 View commit details
    Browse the repository at this point in the history

  2. Simplify 

    Signed-off-by: Hynek Schlawack <hs@ox.cx>
    @hynek
    hynek committed Sep 3, 2020
    Copy the full SHA
    7904888 View commit details
    Browse the repository at this point in the history

  3. Be defensive about __bases__ 

    Signed-off-by: Hynek Schlawack <hs@ox.cx>
    @hynek
    hynek committed Sep 3, 2020
    Copy the full SHA
    e0ffd23 View commit details
    Browse the repository at this point in the history

  4. _Classes_ always have a __dict__

    @hynek
    hynek committed Sep 3, 2020
    Copy the full SHA
    c2b6a0b View commit details
    Browse the repository at this point in the history

  5. Tighten xfail

    @hynek
    hynek committed Sep 3, 2020
    Copy the full SHA
    3adf48a View commit details
    Browse the repository at this point in the history

  6. Clarify what need to be reset and when 

    Signed-off-by: Hynek Schlawack <hs@ox.cx>
    @hynek
    hynek committed Sep 3, 2020
    Copy the full SHA
    5644d21 View commit details
    Browse the repository at this point in the history

  7. Reset __attrs_own_setattr__ along with __setattr__ 

    Signed-off-by: Hynek Schlawack <hs@ox.cx>
    @hynek
    hynek committed Sep 3, 2020
    Copy the full SHA
    f144cfa View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Update src/attr/_make.py 

    Co-authored-by: Paul Ganssle <paul@ganssle.io>
    @hynek @pganssle
    hynek and pganssle committed Sep 4, 2020
    Copy the full SHA
    aea0a7b View commit details
    Browse the repository at this point in the history

  2. Differentiate between own (= attrs) and custom (= user) __setattrs__ 

    Signed-off-by: Hynek Schlawack <hs@ox.cx>
    @hynek
    hynek committed Sep 4, 2020
    Copy the full SHA
    c5b690f View commit details
    Browse the repository at this point in the history

  3. We've always used __bases__ in our call to type() 

    So no reason for being defensive.
    @hynek
    hynek committed Sep 4, 2020
    Copy the full SHA
    32597f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2020

  1. Update tests/test_setattr.py 

    Co-authored-by: Paul Ganssle <paul@ganssle.io>
    @hynek @pganssle
    hynek and pganssle committed Sep 5, 2020
    Copy the full SHA
    0c0c8c7 View commit details
    Browse the repository at this point in the history