Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nbQA for notebook and docs linting #361

Merged
merged 9 commits into from Apr 7, 2023
Merged

Add nbQA for notebook and docs linting #361

merged 9 commits into from Apr 7, 2023

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Sep 19, 2022

Description

This is now possible after nbQA-dev/nbQA#745 which solved this issue (nbQA-dev/nbQA#668) I opened a year ago.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt basnijholt changed the title Add NBQA for notebook and docs linting Add nbQA for notebook and docs linting Sep 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #361 (65cfe02) into main (81464a3) will increase coverage by 0.07%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   78.06%   78.13%   +0.07%     
==========================================
  Files          38       38              
  Lines        5529     5529              
  Branches      989      989              
==========================================
+ Hits         4316     4320       +4     
+ Misses       1060     1058       -2     
+ Partials      153      151       -2     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@basnijholt basnijholt merged commit 0590be6 into main Apr 7, 2023
14 of 21 checks passed
@basnijholt basnijholt deleted the nbqa branch April 7, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants