-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure save_dataframe writes atomically by default #182
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 72.88% 73.46% +0.58%
==========================================
Files 22 22
Lines 2482 2480 -2
==========================================
+ Hits 1809 1822 +13
+ Misses 673 658 -15 ☔ View full report in Codecov by Sentry. |
2e14869
to
eecce41
Compare
There was some issue with atomicwrites being yanked from pypi by its maintainer. |
Can also be done like this: python-adaptive/adaptive#353 |
Does that handle calling |
Not sure about all the details. I just remembered the panic a few years back when the package was yanked, hehe. And python-adaptive/adaptive#352 but adding it here again is fine |
85fd8d5
to
743961b
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
d28be45
to
b2ca7dc
Compare
for more information, see https://pre-commit.ci
Python 3.9 CI job seems to consistently get stuck? |
Yes, no idea what is causing this, and cannot reproduce locally. |
This PR makes it so that 'save_dataframe' writes atomically by default.
This is important for maintaining data integrity during an adaptive scheduler run.
This adds a dependency on the 'atomicwrites' package.
Closes #181.