fix: Use generic_err constructor instead of literal #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@apollo-sturdy is attempting to deploy a commit to the pyth-web Team on Vercel. A member of the Team first needs to authorize it. |
|
I checked that this passes the pre-commit checks locally. I think pre-commit tends to fail on external contributions for some reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cosmwasm-std
StdErrorstruct has a feature-gated fieldbacktracesthat you forgot to fill. This breaks compilation for anyone who depends on the Pyth SDK and tries to enable the backtraces feature. This PR simply uses theStdError::generic_errinstead of creating the struct literal so that you don't have create the backtrace yourself.See this issue for more info: CosmWasm/cosmwasm#1760