[eth] Use PythErrors everywhere #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-bahjati
force-pushed
the
abehjati/eth-use-error-struct
branch
from
b8cff2a
to
f28d5ab
Compare
ali-bahjati
changed the title
Mutation might cause some BytesLib error too.
njk-64
approved these changes
Nov 29, 2022
jayantk
approved these changes
Nov 29, 2022
ali-bahjati
force-pushed
the
abehjati/eth-use-error-struct
branch
from
3717529
to
1f1f8d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses PythErrors structs instead of error strings everywhere and updates the tests (both truffle and foundry). This change reduces contract size from 23.69KB to 20.94KB.
Notes:
revert. So I changed allrequirestatements torevert.expectRevertCustomError.