Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(!): Docker Compose V2 #98

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

tmeckel
Copy link

@tmeckel tmeckel commented Oct 17, 2022

This PR contains changes to support Docker Compose V2 which has been re-implemented using Go by Docker Inc.

Breaking Change:
Python 3.6 is no longer supported because Python-On-Whales do not support Python 3.6

Closes: #97

@tmeckel
Copy link
Author

tmeckel commented Oct 20, 2022

@todofixthis who's responsible for checking on this pull request?

@th0ger
Copy link

th0ger commented Oct 25, 2022

Also @RmStorm seems to have maintained this repo, but there's open PR from 2020, so really no traction.

gjoseph92 added a commit to gjoseph92/sneks that referenced this pull request Nov 19, 2022
pytest-docker-compose/pytest-docker-compose#98 seems to work??

also multi-stage docker build for tests, have test wait for client to come up, etc.
Copy link

@radusuciu radusuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! Will test in a fork and report back. Might take a crack at polishing this project back up since I depend on it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for Docker Compose V2 - docker compose
3 participants