-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Docker Compose V2 - docker compose
#97
Comments
Alternative title: Add Support for Docker Compose V2 - This issue should be marked high importance. Docker compose V1 is marked as deprecated and went out of support. The latest avalable release was V1 is 1.29.2 (May 2021), and even patches are no longer shipped. Lots of features are being added to the Compose V2 format, and since docker compose is the essentail dependency for this project, it's key to keep up-to-date. And yes, implementation changed from Python to Go. Note on: EDIT: Looking at PR/Commits this project may already be dead? |
docker compose
docker compose
docker compose
docker compose
docker compose
I'm just dropping this here: https://www.docker.com/blog/guest-post-calling-the-docker-cli-from-python-with-python-on-whales/ That allows you to call docker compose from python. Disclaimer: I made this package :) |
@gabrieldemarmiesse, @danielgafni, @th0ger I filed PR #98 which uses Python on Whales to support Docker Compose V2 |
@gabrieldemarmiesse, @danielgafni, @th0ger As long as the PR #98 isn't merged and the package has been published to PyPi the following statement can be used in a
Using the V2 version in 4 customer projects right now and it works flawlessly on Linux. |
Maybe it's time to create a new package on pypi? pytest-docker-compose-v2? since it supports docker compose v2? :) |
I think it would be better to add more maintainers if possible. There are lost if issues and PRs here that shouldn't get lost. I see that @todofixthis is currently active on GH, so maybe some haloween candy can trick him out of the cave. A v2 package would make sense from a technical perspective if it proves too hard to support both compose v1 and v2 in the same py package. |
I find this package useful and I made this fork including @tmeckel's PR with the intent to make it easy for me to maintain going forward (ie. some changes are subjective, eg. using PDM as a package manager): https://github.com/radusuciu/pytest-docker-compose-v2 available on pypi: https://pypi.org/project/pytest-docker-compose-v2/ happy to merge back here if maintainers prefer that |
Hey!
A general question here: since
docker-compose
is now written in Go, the old Python package will eventually become unusable. I already got some errors when trying to installpytest-docker-compose
in my project alongsideflet
:The issue he is with the
websocket-client
dependency. Thedocker-compose
package requires an old version of it.Anyway, what would the maintainers do about it? Should this awesome package be refactored to use
/bin/docker-compose
?Thanks in advance!
The text was updated successfully, but these errors were encountered: