Delay warning about collector/item diamond inheritance #9646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
commented
Feb 8, 2022
src/_pytest/nodes.py
Outdated
|
|
||
| # Set of node types to avoid issuing a diamond inheritance warning | ||
| # for the same class more than once, which is not helpful. | ||
| _DIAMOND_COLLECTOR_WARNING: ClassVar[Set[Type["Item"]]] = set() |
There was a problem hiding this comment.
Not sure we want this, might be better to just let we issue multiple warnings and let users filter them. Thoughts?
There was a problem hiding this comment.
Any thoughts on this particular aspect? @RonnyPfannschmidt @The-Compiler ?
There was a problem hiding this comment.
"classically" warnings once filters should sort that, however as we cant rely on them like wed like, i think its fine to do this hack
There was a problem hiding this comment.
@nicoddemus we might however use a boolean on each individual type instance instead of the set in the base class
bluetech
approved these changes
Feb 8, 2022
ghost
approved these changes
Feb 10, 2022
RonnyPfannschmidt
approved these changes
Feb 10, 2022
This allows that warning to be filtered by `filterwarnings`. Fix pytest-dev#9643
nicoddemus
force-pushed
the
9643-delay-warning
branch
from
9b209a1
to
88c3512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows that warning to be filtered by
filterwarnings.Fix #9643