Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python3.6 in CI, setup.cfg, and readme. #9442

Merged
merged 7 commits into from Dec 30, 2021
Merged

Drop Python3.6 in CI, setup.cfg, and readme. #9442

merged 7 commits into from Dec 30, 2021

Conversation

hramezani
Copy link
Member

Part of #9437

bluetech
bluetech reviewed Dec 25, 2021
View reviewed changes
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @hramezani!

Let's wait a bit to give time for objections in issue #9437, then we can merge.

Only this is that it needs a breaking changelog entry - see instructions here.

asottile
asottile reviewed Dec 26, 2021
View reviewed changes
src/_pytest/compat.py Outdated Show resolved Hide resolved
asottile
asottile reviewed Dec 26, 2021
View reviewed changes
testing/test_debugging.py Outdated Show resolved Hide resolved
nicoddemus
nicoddemus requested changes Dec 26, 2021
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for working on this!

I checked out your branch, and in rewrite.py:379 we have:

has_flags = sys.version_info >= (3, 7)

has_flags is always True now, so the conditions below which use it can be simplified. 👍

@hramezani
Copy link
Member Author

Thanks @RonnyPfannschmidt, @asottile, and @nicoddemus for the review.
I've addressed all your comments.

nicoddemus
nicoddemus approved these changes Dec 26, 2021
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I missed two paragraphs which should have 3.10 added to them, I will apply them myself.

doc/en/getting-started.rst Outdated Show resolved Hide resolved
doc/en/index.rst Outdated Show resolved Hide resolved
@bluetech
Copy link
Member

I removed py36 from the required checks.

@nicoddemus nicoddemus mentioned this pull request Dec 27, 2021
Closed
Zac-HD
Zac-HD reviewed Dec 28, 2021
View reviewed changes
doc/en/how-to/skipping.rst Outdated Show resolved Hide resolved
nicoddemus
nicoddemus reviewed Dec 28, 2021
View reviewed changes
doc/en/index.rst Outdated Show resolved Hide resolved
doc/en/getting-started.rst Outdated Show resolved Hide resolved
@nicoddemus
Copy link
Member

Thanks @hramezani!

asottile
asottile approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc/en/index.rst Outdated
@@ -17,7 +17,7 @@ The ``pytest`` framework makes it easy to write small, readable tests, and can
scale to support complex functional testing for applications and libraries.


**Pythons**: ``pytest`` requires: Python 3.6, 3.7, 3.8, 3.9, or PyPy3.
``pytest`` requires: Python 3.7+ and PyPy3.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think or makes more sense here (and below)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also changed Python 3.6+ and PyPy3 to Python 3.6+ or PyPy3 in Features section of README.
Does it also make sence?

@hramezani hramezani force-pushed the drop_python_36 branch 2 times, most recently from 24d6b1d to b0e0373 Compare December 28, 2021 14:14
asottile
asottile approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoefling
Copy link
Member

Out of curiosity, will the silencing of

pytest/pyproject.toml

Lines 31 to 32 in 1131f23

# produced by python3.6/site.py itself (3.6.7 on Travis, could not trigger it with 3.6.8)."
"ignore:.*U.*mode is deprecated:DeprecationWarning:(?!(pytest|_pytest))",

still be required when 3.6 is dropped?

@nicoddemus
Copy link
Member

Out of curiosity, will the silencing of

Good catch, probably not and can be removed.

bluetech
bluetech approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can merge now, thanks @hramezani!

@bluetech bluetech merged commit b9663fe into pytest-dev:main Dec 30, 2021
This was referenced Dec 30, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt left review comments

@Zac-HD Zac-HD Zac-HD left review comments

@nicoddemus nicoddemus nicoddemus approved these changes

@bluetech bluetech bluetech approved these changes

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hramezani @bluetech @nicoddemus @hoefling @RonnyPfannschmidt @asottile @Zac-HD