Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid specialized assert formatting when we detect that __eq__ is overridden #9407

Merged
merged 10 commits into from Dec 14, 2021
Merged

Avoid specialized assert formatting when we detect that __eq__ is overridden #9407

merged 10 commits into from Dec 14, 2021

Conversation

yuvalshi0
Copy link
Member

Closes #9362

RonnyPfannschmidt
RonnyPfannschmidt approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me
i didn't dig into the details, but the tests indicate it works as intended

@yuvalshi0 yuvalshi0 merged commit 3bbadda into pytest-dev:main Dec 14, 2021
@kgalias
Copy link

kgalias commented Feb 23, 2022

Any idea for when will this make it to a release?

@nicoddemus nicoddemus mentioned this pull request Feb 23, 2022
Merged
@nicoddemus
Copy link
Member

It will be released in 7.1.0, which we don't have a hard date but should not be long. 👍

@nicoddemus
Copy link
Member

You can follow #9691 to be up to date too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid specialized assert formatting when we detect that __eq__ is overridden
4 participants
@yuvalshi0 @kgalias @nicoddemus @RonnyPfannschmidt