Deprecate Node constuctor fspath argument, and other small changes/fixes #9232
Conversation
Since path <-> fspath are converted to each other, we need to check both before looking at the parent, in case fspath is set but path is not.
The Node ctor will take care of the check.
Only one usage left, and we certainly don't expect more! Rename `_imply_path_only` to `_imply_path`, that's a less confusing name now.
The plans have changed, next version will be 7.0 not 6.3.
bluetech
force-pushed
the
deprecate-node-fspath-args
branch
from
7c11305
to
9e3cc43
Compare
|
From the plugins we test, pytest-flakes will need to be updated, will send a PR. |
|
while i plan to work on it today to pull in the comments, im still slightly suffering from my cold and will take things slow |
|
Fixing the deprecation warnings in pytest-flakes is easier with version-checks. But I'd like the version check to be on @RonnyPfannschmidt @nicoddemus @The-Compiler WDYT? Alternatively I can just add an ignore for this deprecation warning in the plugins tests for now. |
|
Im fine with dev Tag pushed, having towncrier as indicator for setuptools_scm is on my todo Please check the exact dev tag needed for setuptools_scm not to error out |
|
OK, I pushed the tag. |
This is unfortunately a dependency on `py.path` which cannot be moved to an external plugins or eased in any way, so has to be deprecated in order for pytest to be able to eventually remove the dependency on `py`.
bluetech
force-pushed
the
deprecate-node-fspath-args
branch
from
9e3cc43
to
7706fd6
Compare
|
pytest-flakes was updated, so this is good to go. |
The main thing here is formally deprecating the
fspathargument to Node ctors, as discussed in #9208 (comment). Also some other things I noticed - please see the commits.