New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Recommend not integrating with setuptools #9185
[doc] Recommend not integrating with setuptools #9185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text looks good to me, thanks for adding it.
But if someone only glances the best-practices document and sees this title, they will get exactly the wrong idea. Can we make the title itself clear that this is a bad practice?
@bluetech , I re-used the old title (see https://github.com/pytest-dev/pytest/pull/5546/files) so that existing links to the page would go to the right place. But I can change it if you prefer. |
Yes, I think we should change it. In this case, it's not a bad thing to break the URL :) (Also, the PR you linked already broke the link 2 years ago) |
@bluetech, Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
As discussed in #5534 (comment), I thought it was worth including a notice that integration with setuptools should not be used. I still see projects using
setup.py test
and the pytest docs seems like the most discoverable place for people to find this.