Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Mark Python 3.10 as experimental #8553

Closed

Conversation

The-Compiler
Copy link
Member

It currently breaks all builds and even after #8540 it looks like tests
still fail because of benjaminp/six#341

As a hotfix, mark it as experimental until everything is fixed, so that
our CI isn't all red.

It currently breaks all builds and even after pytest-dev#8540 it looks like tests
still fail because of benjaminp/six#341

As a hotfix, mark it as experimental until everything is fixed, so that
our CI isn't all red.
@The-Compiler
Copy link
Member Author

Hm, looks like CI still is marked as failed. Not sure what I'm missing?

@nicoddemus
Copy link
Member

nicoddemus commented Apr 14, 2021

Thanks Florian!

But I'm not sure we need this: I did research this a bit previously (can't look for the links now), but seems the official GH Actions stance on "marking a build as allowed to fail" is to make the build not required in the repository settings, which we already do:

image

The effect is that even though 3.10 has failed here, the "merge" button is still enabled (in the screenshot above if ubuntu-py36 failed, then the merge button wouldn't be enabled).

@The-Compiler
Copy link
Member Author

GitHub documents it as:

You can allow specific jobs in a job matrix to fail without failing the workflow run.

And indeed looking at the icon at the top left, the workflow run passed - but it doesn't seem to affect the PRs being marked as failure. So yeah, let's close this, as it doesn't really help much after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants