-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix required_plugins with prereleases #8469
Fix required_plugins with prereleases #8469
Conversation
@@ -1270,14 +1270,16 @@ def _validate_plugins(self) -> None: | |||
missing_plugins = [] | |||
for required_plugin in required_plugins: | |||
try: | |||
spec = Requirement(required_plugin) | |||
req = Requirement(required_plugin) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took the freedom to rename this, as spec
is very close to specifier
(another thing in packaging
, see .specifier
below) which I found confusing.
pytest.param( | ||
""" | ||
[pytest] | ||
required_plugins = myplugin==1.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at the two commits individually to get a better diff (also see the comment below).
c0398f8
to
57e69b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Left a small CHANGELOG suggestion.
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
Thanks @nicoddemus for the review, and @RonnyPfannschmidt @asottile for the suggestions in #8456! |
Fixes #8456