Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py36+: remove _pytest.compat.fspath #7839

Merged
merged 1 commit into from Oct 3, 2020
Merged

py36+: remove _pytest.compat.fspath #7839

merged 1 commit into from Oct 3, 2020

Conversation

asottile
Copy link
Member

@asottile asottile commented Oct 3, 2020

See #7808

bluetech
bluetech approved these changes Oct 3, 2020
View reviewed changes
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also a bunch of places where we do something(str(path)) instead of just something(path) because the something only supports the fspath protocol since 3.6. But they are probably harder to track.

@asottile asottile merged commit c2a197f into pytest-dev:master Oct 3, 2020
@asottile asottile deleted the py36_compat_fspath branch October 3, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

@bluetech bluetech bluetech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asottile @nicoddemus @bluetech