Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py36+: remove TYPE_CHECKING from _pytest.compat #7834

Merged
merged 1 commit into from Oct 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/en/conf.py
Expand Up @@ -17,9 +17,9 @@
# The short X.Y version.
import os
import sys
from typing import TYPE_CHECKING

from _pytest import __version__ as version
from _pytest.compat import TYPE_CHECKING

if TYPE_CHECKING:
import sphinx.application
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/_code/code.py
Expand Up @@ -21,6 +21,7 @@
from typing import Sequence
from typing import Set
from typing import Tuple
from typing import TYPE_CHECKING
from typing import TypeVar
from typing import Union
from weakref import ref
Expand All @@ -40,7 +41,6 @@
from _pytest.compat import final
from _pytest.compat import get_real_func
from _pytest.compat import overload
from _pytest.compat import TYPE_CHECKING
from _pytest.pathlib import Path

if TYPE_CHECKING:
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/assertion/__init__.py
Expand Up @@ -4,12 +4,12 @@
from typing import Generator
from typing import List
from typing import Optional
from typing import TYPE_CHECKING

from _pytest.assertion import rewrite
from _pytest.assertion import truncate
from _pytest.assertion import util
from _pytest.assertion.rewrite import assertstate_key
from _pytest.compat import TYPE_CHECKING
from _pytest.config import Config
from _pytest.config import hookimpl
from _pytest.config.argparsing import Parser
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/assertion/rewrite.py
Expand Up @@ -22,6 +22,7 @@
from typing import Sequence
from typing import Set
from typing import Tuple
from typing import TYPE_CHECKING
from typing import Union

import py
Expand All @@ -33,7 +34,6 @@
format_explanation as _format_explanation,
)
from _pytest.compat import fspath
from _pytest.compat import TYPE_CHECKING
from _pytest.config import Config
from _pytest.main import Session
from _pytest.pathlib import fnmatch_ex
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/capture.py
Expand Up @@ -14,11 +14,11 @@
from typing import Optional
from typing import TextIO
from typing import Tuple
from typing import TYPE_CHECKING
from typing import Union

import pytest
from _pytest.compat import final
from _pytest.compat import TYPE_CHECKING
from _pytest.config import Config
from _pytest.config.argparsing import Parser
from _pytest.fixtures import SubRequest
Expand Down
7 changes: 1 addition & 6 deletions src/_pytest/compat.py
Expand Up @@ -14,6 +14,7 @@
from typing import Optional
from typing import overload as overload
from typing import Tuple
from typing import TYPE_CHECKING
from typing import TypeVar
from typing import Union

Expand All @@ -22,12 +23,6 @@
from _pytest.outcomes import fail
from _pytest.outcomes import TEST_OUTCOME

if sys.version_info < (3, 5, 2):
TYPE_CHECKING = False # type: bool
else:
from typing import TYPE_CHECKING


if TYPE_CHECKING:
from typing import NoReturn
from typing import Type
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/config/__init__.py
Expand Up @@ -26,6 +26,7 @@
from typing import Set
from typing import TextIO
from typing import Tuple
from typing import TYPE_CHECKING
from typing import Union

import attr
Expand All @@ -45,7 +46,6 @@
from _pytest._io import TerminalWriter
from _pytest.compat import final
from _pytest.compat import importlib_metadata
from _pytest.compat import TYPE_CHECKING
from _pytest.outcomes import fail
from _pytest.outcomes import Skipped
from _pytest.pathlib import bestrelpath
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/config/argparsing.py
Expand Up @@ -11,13 +11,13 @@
from typing import Optional
from typing import Sequence
from typing import Tuple
from typing import TYPE_CHECKING
from typing import Union

import py

import _pytest._io
from _pytest.compat import final
from _pytest.compat import TYPE_CHECKING
from _pytest.config.exceptions import UsageError

if TYPE_CHECKING:
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/config/findpaths.py
Expand Up @@ -5,12 +5,12 @@
from typing import Optional
from typing import Sequence
from typing import Tuple
from typing import TYPE_CHECKING
from typing import Union

import iniconfig

from .exceptions import UsageError
from _pytest.compat import TYPE_CHECKING
from _pytest.outcomes import fail
from _pytest.pathlib import absolutepath
from _pytest.pathlib import commonpath
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/debugging.py
Expand Up @@ -9,11 +9,11 @@
from typing import List
from typing import Optional
from typing import Tuple
from typing import TYPE_CHECKING
from typing import Union

from _pytest import outcomes
from _pytest._code import ExceptionInfo
from _pytest.compat import TYPE_CHECKING
from _pytest.config import Config
from _pytest.config import ConftestImportFailure
from _pytest.config import hookimpl
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/doctest.py
Expand Up @@ -17,6 +17,7 @@
from typing import Pattern
from typing import Sequence
from typing import Tuple
from typing import TYPE_CHECKING
from typing import Union

import py.path
Expand All @@ -28,7 +29,6 @@
from _pytest._code.code import TerminalRepr
from _pytest._io import TerminalWriter
from _pytest.compat import safe_getattr
from _pytest.compat import TYPE_CHECKING
from _pytest.config import Config
from _pytest.config.argparsing import Parser
from _pytest.fixtures import FixtureRequest
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/fixtures.py
Expand Up @@ -19,6 +19,7 @@
from typing import Sequence
from typing import Set
from typing import Tuple
from typing import TYPE_CHECKING
from typing import TypeVar
from typing import Union

Expand All @@ -43,7 +44,6 @@
from _pytest.compat import order_preserving_dict
from _pytest.compat import overload
from _pytest.compat import safe_getattr
from _pytest.compat import TYPE_CHECKING
from _pytest.config import _PluggyPlugin
from _pytest.config import Config
from _pytest.config.argparsing import Parser
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/hookspec.py
Expand Up @@ -7,12 +7,12 @@
from typing import Optional
from typing import Sequence
from typing import Tuple
from typing import TYPE_CHECKING
from typing import Union

import py.path
from pluggy import HookspecMarker

from _pytest.compat import TYPE_CHECKING
from _pytest.deprecated import WARNING_CAPTURED_HOOK

if TYPE_CHECKING:
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/main.py
Expand Up @@ -14,6 +14,7 @@
from typing import Sequence
from typing import Set
from typing import Tuple
from typing import TYPE_CHECKING
from typing import Union

import attr
Expand All @@ -23,7 +24,6 @@
from _pytest import nodes
from _pytest.compat import final
from _pytest.compat import overload
from _pytest.compat import TYPE_CHECKING
from _pytest.config import Config
from _pytest.config import directory_arg
from _pytest.config import ExitCode
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/mark/__init__.py
Expand Up @@ -4,6 +4,7 @@
from typing import AbstractSet
from typing import List
from typing import Optional
from typing import TYPE_CHECKING
from typing import Union

import attr
Expand All @@ -17,7 +18,6 @@
from .structures import MarkDecorator
from .structures import MarkGenerator
from .structures import ParameterSet
from _pytest.compat import TYPE_CHECKING
from _pytest.config import Config
from _pytest.config import ExitCode
from _pytest.config import hookimpl
Expand Down
3 changes: 1 addition & 2 deletions src/_pytest/mark/expression.py
Expand Up @@ -23,11 +23,10 @@
from typing import Mapping
from typing import Optional
from typing import Sequence
from typing import TYPE_CHECKING

import attr

from _pytest.compat import TYPE_CHECKING

if TYPE_CHECKING:
from typing import NoReturn

Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/mark/structures.py
Expand Up @@ -13,6 +13,7 @@
from typing import Sequence
from typing import Set
from typing import Tuple
from typing import TYPE_CHECKING
from typing import TypeVar
from typing import Union

Expand All @@ -24,7 +25,6 @@
from ..compat import NOTSET
from ..compat import NotSetType
from ..compat import overload
from ..compat import TYPE_CHECKING
from _pytest.config import Config
from _pytest.outcomes import fail
from _pytest.warning_types import PytestUnknownMarkWarning
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/nodes.py
Expand Up @@ -10,6 +10,7 @@
from typing import Optional
from typing import Set
from typing import Tuple
from typing import TYPE_CHECKING
from typing import TypeVar
from typing import Union

Expand All @@ -21,7 +22,6 @@
from _pytest._code.code import TerminalRepr
from _pytest.compat import cached_property
from _pytest.compat import overload
from _pytest.compat import TYPE_CHECKING
from _pytest.config import Config
from _pytest.config import ConftestImportFailure
from _pytest.deprecated import FSCOLLECTOR_GETHOOKPROXY_ISINITPATH
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/pytester.py
Expand Up @@ -18,6 +18,7 @@
from typing import Optional
from typing import Sequence
from typing import Tuple
from typing import TYPE_CHECKING
from typing import Union
from weakref import WeakKeyDictionary

Expand All @@ -30,7 +31,6 @@
from _pytest.capture import _get_multicapture
from _pytest.compat import final
from _pytest.compat import overload
from _pytest.compat import TYPE_CHECKING
from _pytest.config import _PluggyPlugin
from _pytest.config import Config
from _pytest.config import ExitCode
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/python.py
Expand Up @@ -23,6 +23,7 @@
from typing import Optional
from typing import Set
from typing import Tuple
from typing import TYPE_CHECKING
from typing import Union

import py
Expand All @@ -49,7 +50,6 @@
from _pytest.compat import safe_getattr
from _pytest.compat import safe_isclass
from _pytest.compat import STRING_TYPES
from _pytest.compat import TYPE_CHECKING
from _pytest.config import Config
from _pytest.config import ExitCode
from _pytest.config import hookimpl
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/python_api.py
Expand Up @@ -13,14 +13,14 @@
from typing import Optional
from typing import Pattern
from typing import Tuple
from typing import TYPE_CHECKING
from typing import TypeVar
from typing import Union

import _pytest._code
from _pytest.compat import final
from _pytest.compat import overload
from _pytest.compat import STRING_TYPES
from _pytest.compat import TYPE_CHECKING
from _pytest.outcomes import fail

if TYPE_CHECKING:
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/recwarn.py
Expand Up @@ -10,12 +10,12 @@
from typing import Optional
from typing import Pattern
from typing import Tuple
from typing import TYPE_CHECKING
from typing import TypeVar
from typing import Union

from _pytest.compat import final
from _pytest.compat import overload
from _pytest.compat import TYPE_CHECKING
from _pytest.fixtures import fixture
from _pytest.outcomes import fail

Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/reports.py
Expand Up @@ -8,6 +8,7 @@
from typing import List
from typing import Optional
from typing import Tuple
from typing import TYPE_CHECKING
from typing import TypeVar
from typing import Union

Expand All @@ -27,7 +28,6 @@
from _pytest._code.code import TerminalRepr
from _pytest._io import TerminalWriter
from _pytest.compat import final
from _pytest.compat import TYPE_CHECKING
from _pytest.config import Config
from _pytest.nodes import Collector
from _pytest.nodes import Item
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/runner.py
Expand Up @@ -9,6 +9,7 @@
from typing import List
from typing import Optional
from typing import Tuple
from typing import TYPE_CHECKING
from typing import TypeVar
from typing import Union

Expand All @@ -23,7 +24,6 @@
from _pytest._code.code import ExceptionInfo
from _pytest._code.code import TerminalRepr
from _pytest.compat import final
from _pytest.compat import TYPE_CHECKING
from _pytest.config.argparsing import Parser
from _pytest.nodes import Collector
from _pytest.nodes import Item
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/skipping.py
Expand Up @@ -6,10 +6,10 @@
from typing import Generator
from typing import Optional
from typing import Tuple
from typing import TYPE_CHECKING

import attr

from _pytest.compat import TYPE_CHECKING
from _pytest.config import Config
from _pytest.config import hookimpl
from _pytest.config.argparsing import Parser
Expand Down
2 changes: 1 addition & 1 deletion src/_pytest/terminal.py
Expand Up @@ -20,6 +20,7 @@
from typing import Set
from typing import TextIO
from typing import Tuple
from typing import TYPE_CHECKING
from typing import Union

import attr
Expand All @@ -34,7 +35,6 @@
from _pytest._io.wcwidth import wcswidth
from _pytest.compat import final
from _pytest.compat import order_preserving_dict
from _pytest.compat import TYPE_CHECKING
from _pytest.config import _PluggyPlugin
from _pytest.config import Config
from _pytest.config import ExitCode
Expand Down