terminal: fix crash in header reporting when testpaths is used without cli arguments #7816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t cli arguments Regressed in 6.1.0 in 62e249a. The `x` is an `str` but is expected to be a `pathlib.Path`. Not caught by mypy because `config.getini()` returns `Any`. The code was actually wrong before, even `py.path.local`'s `bestrelpath` function expects a `py.path.local`, not an `str`. But it had some weird `try ... except AttributeError` fallback which just returns the argument, i.e. it was a no-op.
bluetech
added
the
needs backport
4 tasks
|
Hmm it doesn't work well on Windows, will take a look later. |
|
Looking at this a bit more, I'll go with a different approach. |
bluetech
removed
the
needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7814.
Regressed in 6.1.0 in 62e249a. The
xis anstrbut is expected to be apathlib.Path. Not caught by mypy becauseconfig.getini()returnsAny.The code was actually wrong before, even
py.path.local'sbestrelpathfunction expects apy.path.local, not anstr. But it had some weirdtry ... except AttributeErrorfallback which just returns the argument, i.e. it was a no-op.