Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark some public and to-be-public classes as @final #7780

Merged
merged 1 commit into from Sep 23, 2020

Commits on Sep 22, 2020

  1. Mark some public and to-be-public classes as @final

    This indicates at least for people using type checkers that these
    classes are not designed for inheritance and we make no stability
    guarantees regarding inheritance of them.
    
    Currently this doesn't show up in the docs. Sphinx does actually support
    `@final`, however it only works when imported directly from `typing`,
    while we import from `_pytest.compat`.
    
    In the future there might also be a `@sealed` decorator which would
    cover some more cases.
    bluetech committed Sep 22, 2020
    Copy the full SHA
    a99ca87 View commit details
    Browse the repository at this point in the history