Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging: fix handler level restored incorrectly if caplog.set_level is called more than once #7673

Merged
merged 1 commit into from Aug 23, 2020
Merged

logging: fix handler level restored incorrectly if caplog.set_level is called more than once #7673

merged 1 commit into from Aug 23, 2020

Conversation

bluetech
Copy link
Member

Fixes #7672.

@bluetech bluetech added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Aug 22, 2020
nicoddemus
nicoddemus approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@bluetech bluetech merged commit 143e3ab into pytest-dev:master Aug 23, 2020
bluetech added a commit to bluetech/pytest that referenced this pull request Aug 23, 2020
@bluetech
Merge pull request pytest-dev#7673 from bluetech/logging-fix-handler-…
834f55e 
…restore

logging: fix handler level restored incorrectly if caplog.set_level is called more than once
(cherry picked from commit 143e3ab)
@bluetech bluetech mentioned this pull request Aug 23, 2020
Merged
@bluetech bluetech deleted the logging-fix-handler-restore branch August 24, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twmr twmr twmr approved these changes

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logging: handler level restored incorrectly if caplog.set_level is called more than once
3 participants
@bluetech @twmr @nicoddemus