Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: fix capture handler level not reset on teardown after caplog.set_level() #7571

Merged

Conversation

bluetech
Copy link
Member

Fixes #7569.

This probably regressed in fcbaab8.

@bluetech bluetech added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Jul 29, 2020
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @bluetech!

@nicoddemus
Copy link
Member

I'll backport it. 👍

@nicoddemus nicoddemus merged commit cefe064 into pytest-dev:master Jul 29, 2020
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Jul 29, 2020
…dler-restore

logging: fix capture handler level not reset on teardown after caplog.set_level()
@nicoddemus
Copy link
Member

Backport: #7573

@nicoddemus nicoddemus added backported PR has been backported to the current bug-fix branch and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported PR has been backported to the current bug-fix branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

caplog fixture doesn't restore log level after test
2 participants