Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark: fix pylint not-callable error on pytest.mark.parametrize(...), again #7565

Merged
merged 1 commit into from Jul 29, 2020

Conversation

bluetech
Copy link
Member

Fixes #7558, Refs #7473. Previous attempt: #7476.

Apparently the previous fix c1ca42b didn't work. Hopefully this time I'm testing this correctly.

…again

Apparently the previous fix c1ca42b didn't work.
Hopefully this time I'm testing this correctly.
Copy link
Member

@The-Compiler The-Compiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me after a pip install -e git+https://github.com/bluetech/pytest@pylint-callable-2#egg=pytest FWIW!

@bluetech
Copy link
Member Author

Thanks for checking @The-Compiler. I'm more confident this one does the trick, so I'm merging and will do a backport.

@bluetech bluetech merged commit f9837f9 into pytest-dev:master Jul 29, 2020
bluetech added a commit to bluetech/pytest that referenced this pull request Jul 29, 2020
mark: fix pylint not-callable error on pytest.mark.parametrize(...), again
(cherry picked from commit f9837f9)
Comment on lines +479 to +481
parametrize = _ParametrizeMarkDecorator(Mark("parametrize ", (), {}))
usefixtures = _UsefixturesMarkDecorator(Mark("usefixtures ", (), {}))
filterwarnings = _FilterwarningsMarkDecorator(Mark("filterwarnings ", (), {}))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason these have an extra space? and skip/skipif/xfail do not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, just a bad vim macro...

@bluetech bluetech added the backported PR has been backported to the current bug-fix branch label Jul 29, 2020
lars-petter-hauge added a commit to lars-petter-hauge/semeio that referenced this pull request Jul 30, 2020
The pylint not-callable error on pytest.mark.parametrize(...)
error is a recurring issue for pytest, but should be fixed now:
pytest-dev/pytest#7565

Did not make it in the 6.0.0 release, pin for now.
lars-petter-hauge added a commit to lars-petter-hauge/semeio that referenced this pull request Jul 30, 2020
The pylint not-callable error on pytest.mark.parametrize(...)
error is a recurring issue for pytest, but should be fixed now:
pytest-dev/pytest#7565

Did not make it in the 6.0.0 release, pin for now.
lars-petter-hauge added a commit to lars-petter-hauge/semeio that referenced this pull request Jul 30, 2020
The pylint not-callable error on pytest.mark.parametrize(...)
error is a recurring issue for pytest, but should be fixed now:
pytest-dev/pytest#7565

Did not make it in the 6.0.0 release, pin for now.
lars-petter-hauge added a commit to lars-petter-hauge/semeio that referenced this pull request Jul 30, 2020
The pylint not-callable error on pytest.mark.parametrize(...)
error is a recurring issue for pytest, but should be fixed now:
pytest-dev/pytest#7565

Did not make it in the 6.0.0 release, pin for now.
lars-petter-hauge added a commit to equinor/semeio that referenced this pull request Jul 30, 2020
The pylint not-callable error on pytest.mark.parametrize(...)
error is a recurring issue for pytest, but should be fixed now:
pytest-dev/pytest#7565

Did not make it in the 6.0.0 release, pin for now.
CZNIC-GitLab pushed a commit to CZ-NIC/knot-resolver that referenced this pull request Aug 3, 2020
@bluetech bluetech deleted the pylint-callable-2 branch August 24, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported PR has been backported to the current bug-fix branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest 6: pylint still shows not-callable error for builtin pytest marks even after #7473 and #7476
3 participants