Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --strict imply both strictness options #7529

Closed
wants to merge 1 commit into from
Closed

Make --strict imply both strictness options #7529

wants to merge 1 commit into from

Conversation

The-Compiler
Copy link
Member

RFC for #7503. It looks like there was a consensus that this is the right thing to do, but not on whether this can still go to pytest 6 in such a late stage or should wait for pytest 7.

IMHO it's fine to have in pytest 6 since we already documented this possibility in the changelog for pytest 4.5.0 ("The existing --strict option has the same behavior currently, but can be augmented in the future for additional checks.") and discouraged it in the documentation (The use of --strict-markers is highly preferred. --strict was kept for backward compatibility only and may be confusing for others as it only applies to markers and not to other options.)

Let me know what you think.

@The-Compiler
Copy link
Member Author

Looks like we're not reaching a consensus here in #7503, and it'd be better to deprecate --strict for 6.0 and then take care to get it right in 7.0. Thus I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant