Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor fixes & type annotations #7472

Merged
merged 15 commits into from Jul 11, 2020
Merged

Commits on Jul 10, 2020

  1. Stop using ExceptionInfo.errisinstance internally

    It does the same as a simple isinstance check, but adds a little layer
    of obscurity on top, which the type checker can't penetrate.
    bluetech committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    fb2640b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e079ebb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5da4a1d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c7a1db5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bcff02c View commit details
    Browse the repository at this point in the history
  6. tmpdir: type annotations

    bluetech committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    8e8d639 View commit details
    Browse the repository at this point in the history
  7. hookspec: change Node -> Union[Item, Collector] to avoid exposing Node

    We don't really want `Node` itself as a public API, only its two
    subclasses.
    bluetech committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    168d9ad View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fc702ab View commit details
    Browse the repository at this point in the history
  9. Remove no longer needed noqa: F821 uses

    Not needed since pyflakes 2.2.0.
    bluetech committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    a2f021b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    087b047 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    77f3cb4 View commit details
    Browse the repository at this point in the history
  12. code/code: remove Frame.is_true() method

    Really odd one, let's just inline it.
    bluetech committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    c3864bc View commit details
    Browse the repository at this point in the history
  13. code/code: remove Frame.exec_() method

    Not used.
    bluetech committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    85ef2bf View commit details
    Browse the repository at this point in the history
  14. code/code: remove redundant __ne__ implementation

    This implementation is the default when __eq__ is implemented.
    bluetech committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    c867600 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7934ac2 View commit details
    Browse the repository at this point in the history