Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 6.0.0rc1 #7459

Merged
merged 5 commits into from Jul 10, 2020
Merged

Release 6.0.0rc1 #7459

merged 5 commits into from Jul 10, 2020

Conversation

nicoddemus
Copy link
Member

As discussed in #7447.

blueyed
blueyed reviewed Jul 7, 2020
View reviewed changes
doc/en/changelog.rst
Deprecations
------------

- `#6981 <https://github.com/pytest-dev/pytest/issues/6981>`_: Deprecate the ``pytest.collect`` module as it's just aliases into ``pytest``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a known regression with this already: #6981 (comment)
(IIRC it does not happen with #6803)

@hugovk
Copy link
Member

hugovk commented Jul 8, 2020

Is #7362 ("Change pytest deprecation warnings into errors for 6.0 release") needed for this?

@nicoddemus
Copy link
Member Author

Is #7362 ("Change pytest deprecation warnings into errors for 6.0 release") needed for this?

I think so yes, this way release testers can try removing the warnings and reporting any problems. 👍

asottile
asottile approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good

doc/en/getting-started.rst Outdated Show resolved Hide resolved
asottile
asottile approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoddemus
Copy link
Member Author

Unfortunately TestParseIni::test_missing_required_plugins depends on 1.32.0 being the last pytest-xdist release, so 1.33.0 which I just published specifically to release 6.0.0rc1 broke the tests.

I will make the release manually for now, given that this is really a problem with the tests and not with the code, and will fix the tests shortly in a separate PR.

@nicoddemus nicoddemus merged commit 0a0c14d into pytest-dev:master Jul 10, 2020
@nicoddemus nicoddemus deleted the release-6.0.0rc1 branch July 10, 2020 00:26
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Jul 10, 2020
@nicoddemus
Make test_missing_required_plugins xdist-independent
be7b02c 
Also cleaned up the parametrized list using `pytest.param` to assign ids
and removed some redundant cases.

Follow up to pytest-dev#7459
@nicoddemus nicoddemus mentioned this pull request Jul 10, 2020
Merged
@asottile
Copy link
Member

@nicoddemus looks like the github release notes got missed: https://github.com/pytest-dev/pytest/releases/tag/6.0.0rc1

I assume this is related to the manual release?

@nicoddemus
Copy link
Member Author

Ahh right, indeed it is, thanks for the heads up.

Given that this is a prerelease I'm willing to leave it at that for now, unless someone really complains about it. 😁

@asottile
Copy link
Member

alrighty sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueyed blueyed blueyed left review comments

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicoddemus @hugovk @asottile @blueyed