Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New testdir-like fixture using pathlib #7425

Closed
wants to merge 5 commits into from
Closed

New testdir-like fixture using pathlib #7425

wants to merge 5 commits into from

Commits on Jul 11, 2020

  1. Change Testdir to only use pathlib internally

    @nicoddemus
    nicoddemus committed Jul 11, 2020
    Copy the full SHA
    ded45e0 View commit details
    Browse the repository at this point in the history

  2. Add TestPath class and test_path fixture 

    Also change Testdir to be a thin wrapper which only delegates to TestPath. An
alternative would be to subclass and only overwrite the methods that return
Path to convert the return to py.path.local, but this was preferred so we don't
expose Path-returning objects by accident and to expose exactly what we want
in Testdir.
    @nicoddemus
    nicoddemus committed Jul 11, 2020
    Copy the full SHA
    5eba34a View commit details
    Browse the repository at this point in the history

  3. Convert test_doctest to use test_path and tmp_path

    @nicoddemus
    nicoddemus committed Jul 11, 2020
    Copy the full SHA
    64600a7 View commit details
    Browse the repository at this point in the history

  4. Use test_path in test_no_brokenpipeerror_message 

    It uses a private method which I don't think we should expose in Testdir for now
    @nicoddemus
    nicoddemus committed Jul 11, 2020
    Copy the full SHA
    37298e3 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. Code review suggestions

    @nicoddemus
    nicoddemus committed Jul 14, 2020
    Copy the full SHA
    87a64c9 View commit details
    Browse the repository at this point in the history