Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.6] Fix test_getfslineno for Python 3.9 #7181

Closed
wants to merge 1 commit into from

Conversation

hroncok
Copy link
Member

@hroncok hroncok commented May 7, 2020

inspect.getsource improved in Python 3.9 (utilizing the ast and __qualname__)
See https://bugs.python.org/issue35113

Resolves #7161

inspect.getsource improved in Python 3.9 (utilizing the ast and __qualname__)
See https://bugs.python.org/issue35113

Resolves pytest-dev#7161
@hroncok hroncok mentioned this pull request May 7, 2020
@nicoddemus
Copy link
Member

Thanks a lot for the backport @hroncok!

We however have a documented procedure for the backport, see https://docs.pytest.org/en/latest/py27-py34-deprecation.html in the section "Backporting changes into 4.6". Could you attempt that procedure after #7179 gets merged? Thanks!

@hroncok
Copy link
Member Author

hroncok commented May 7, 2020

Sure.

@hroncok hroncok changed the title 4.6: Fix test_getfslineno for Python 3.9 [4.6] Fix test_getfslineno for Python 3.9 May 7, 2020
@hroncok
Copy link
Member Author

hroncok commented May 7, 2020

See #7190

@hroncok hroncok closed this May 7, 2020
@hroncok hroncok deleted the 4.6.x-py39 branch May 7, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants