fixtures: deprecate pytest._fillfuncargs function #7117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is exposed and kept alive for the oejskit plugin which is abandoned and no longer works with recent plugins, so let's prepare to completely remove it.
bluetech
force-pushed
the
deprecate-fillfuncargs-v2
branch
from
8d56ebf
to
907e29a
Compare
bluetech
commented
Apr 24, 2020
| @@ -1535,7 +1535,7 @@ def setup(self) -> None: | |||
| if isinstance(self.parent, Instance): | |||
| self.parent.newinstance() | |||
| self.obj = self._getobj() | |||
| fixtures.fillfixtures(self) | |||
| self._request._fillfixtures() | |||
There was a problem hiding this comment.
This change shouldn't matter I think because the class here is Function which always has _request defined, so fixtures.fillfixtures does nothing for it except calling self._request._fillfixtures().
RonnyPfannschmidt
approved these changes
Apr 24, 2020
Co-Authored-By: Ronny Pfannschmidt <opensource@ronnypfannschmidt.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is exposed and kept alive for the oejskit plugin which is abandoned and no longer works with recent plugins, so let's prepare to completely remove it.
Replaces #7097 with just the deprecation.