Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

running stdlib asyncio unittests again #6927

Merged
merged 1 commit into from Mar 30, 2020
Merged

running stdlib asyncio unittests again #6927

merged 1 commit into from Mar 30, 2020

Conversation

RonnyPfannschmidt
Copy link
Member

fixes #6924

opting out of the warning+skip revealed that the generators currently don't execute, while on 5.3 they do by accidennt

@RonnyPfannschmidt
Copy link
Member Author

i tried a few approaches to sort out the async result, i'll take a good night of sleep and try again

its likely going to require a semi-permanent hack in python.py

@teemukataja teemukataja mentioned this pull request Mar 18, 2020
Merged
2 tasks
@RonnyPfannschmidt RonnyPfannschmidt force-pushed the fix-6924-run-async-stdlib-unittests branch from ec2cb0f to b2aadb8 Compare March 29, 2020 12:32
@RonnyPfannschmidt RonnyPfannschmidt changed the title WIP: first stake at running stdlib asyncio unittests again running stdlib asyncio unittests again Mar 29, 2020
@nicoddemus
Copy link
Member

i tried a few approaches to sort out the async result, i'll take a good night of sleep and try again

its likely going to require a semi-permanent hack in python.py

Another thought is to update the hook to also somehow forward the result of the function call forward (and hence the async result).

nicoddemus
nicoddemus requested changes Mar 29, 2020
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Missing the CHANGELOG to 😁

@RonnyPfannschmidt RonnyPfannschmidt force-pushed the fix-6924-run-async-stdlib-unittests branch from 0f17bef to e216752 Compare March 30, 2020 19:19
@RonnyPfannschmidt
prepare tests and disable warnings for asyncio unittest cases
451aef6 
shoehorn unittest async results into python test result interpretation

changelog
@RonnyPfannschmidt RonnyPfannschmidt force-pushed the fix-6924-run-async-stdlib-unittests branch from e216752 to 451aef6 Compare March 30, 2020 19:55
@RonnyPfannschmidt RonnyPfannschmidt merged commit 2d9dac9 into pytest-dev:master Mar 30, 2020
@RonnyPfannschmidt
Copy link
Member Author

merged as admin due to the unrelated py37 windows failure

@blueyed blueyed mentioned this pull request Mar 31, 2020
Closed
@nicoddemus
Copy link
Member

Sorry, I just realized we have forgotten to backport this to 5.4.x. Could you take care of that @RonnyPfannschmidt? Thanks! Also I realize there's still work to be done in #6924, but I believe this should also be backported independently from further work.

@RonnyPfannschmidt RonnyPfannschmidt added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Apr 2, 2020
@RonnyPfannschmidt RonnyPfannschmidt added this to the 5.4.2 milestone Apr 2, 2020
@RonnyPfannschmidt RonnyPfannschmidt mentioned this pull request Apr 2, 2020
Closed
3 tasks
RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this pull request Apr 10, 2020
@RonnyPfannschmidt
Merge pull request pytest-dev#6927 from RonnyPfannschmidt/fix-6924-ru…
f5e430f 
…n-async-stdlib-unittests

running stdlib asyncio unittests again
@RonnyPfannschmidt RonnyPfannschmidt mentioned this pull request Apr 10, 2020
Merged
RonnyPfannschmidt added a commit that referenced this pull request Apr 10, 2020
@RonnyPfannschmidt
Merge pull request #7068 from RonnyPfannschmidt/backport-6927-run-asy…
a600e7a 
…nc-unittest

backport #6927: run async testcase methods
@RonnyPfannschmidt RonnyPfannschmidt mentioned this pull request May 1, 2020
Closed
@RonnyPfannschmidt RonnyPfannschmidt deleted the fix-6924-run-async-stdlib-unittests branch June 6, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch
Projects
None yet
Milestone
5.4.2
Development

Successfully merging this pull request may close these issues.

pytest 5.4+ doesn't handle IsolatedAsyncioTestCase from CPython core.
2 participants
@RonnyPfannschmidt @nicoddemus