Commits on Mar 7, 2020

1. Simplify away safe_text_dupfile/EncodedFile …

   I tried to understand what the `safe_text_dupfile()` function and
   `EncodedFile` class do. Outside tests, `EncodedFile` is only used by
   `safe_text_dupfile`, and `safe_text_dupfile` is only used by
   `FDCaptureBinary.__init__()`. I then started to eliminate always-true
   conditions based on the single call site, and in the end nothing was
   left.
   
   The old code had some workarounds:
   
   - Ensure `errors` property is set: pytest-dev#555.
     It is set now, although now it will return `replace`, which is the
     actual method used also before, instead of `strict`. AFAIU, the issue
     just wanted it to be set to something, not `strict` specifically.
   
   - Infinite recursion trying to pickle `EncodedFile` (f7282b8).
     Not sure, I don't think this object should be pickle-able at all (and
     it isn't...).
   
   - A bug in `logging.Handler.__repr__` with int `file.name`.
     pytest-dev#2555
     Was fixed in Python>=3.7.4: https://bugs.python.org/issue36015.
     TODO: This workaround is probably still needed?

   

   bluetech committed Mar 7, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 60f5531
   • Browse repository at this point

   Copy the full SHA

   60f5531 View commit details

   Browse the repository at this point in the history