tests: add test_fixture_arg_ordering #6554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2020
Closed
nicoddemus
approved these changes
Jan 24, 2020
| @@ -4207,3 +4207,32 @@ def test_bug(value): | |||
| ) | |||
| result = testdir.runpytest() | |||
| result.assert_outcomes(passed=10) | |||
|
|
|||
|
|
|||
| def test_fixture_arg_ordering(testdir): | |||
There was a problem hiding this comment.
Suggested change
| def test_fixture_arg_ordering(testdir): | |
| def test_fixture_arg_ordering(testdir): | |
| """ | |
| This test describes how fixtures in the same scope but without explicit dependencies | |
| between them are created. While users should make dependencies explicit, often | |
| they rely on this order, so this test exists to catch regressions in this regard. | |
| See #6540 and #6492. | |
| """ |
There was a problem hiding this comment.
@nicoddemus
Thanks, please squash/force-push your suggestion and merge then.
This is a regression test for part of pytest-dev#6492, testing one of the fixes in pytest-dev#6551.
nicoddemus
force-pushed
the
test_fixture_arg_ordering
branch
from
22a3b14
to
192d3ad
Compare
nicoddemus
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression test for part of
#6492, testing one of the
fixes in #6551.