Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/RFC] fixtures: register finalizers with all previous fixtures in the stack (take 2) #6551

Closed
wants to merge 7 commits into from

Commits on Mar 9, 2020

  1. Configuration menu
    Copy the full SHA
    163b03c View commit details
    Browse the repository at this point in the history
  2. _dependee_fixture_argnames: return tuple

    Note: black cannot parse `return *active_fixture_argnames,
    *self.argnames` yet (fixed in master, psf/black#1121).
    
    Tested manually using:
    ```python
    @pytest.fixture(scope="session")
    def xdist_suffix(request):
        print("\nxdist_suffix")
        suffixes.append("xdist")
    
    @pytest.fixture(scope="session")
    def parallel_suffix(tox_suffix, xdist_suffix):
        pass
    
    def test_suffix(parallel_suffix):
        assert suffixes == ["tox", "xdist"]
    ```
    
    When using a set there the order is not deterministic, i.e. the test is
    flaky.
    blueyed committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    b84d70b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cfee6e7 View commit details
    Browse the repository at this point in the history
  4. cleaned up, DAMPified, and added tests to ensure fixtures only add th…

    …er finalizer to a dependee fixture once
    SalmonMode authored and blueyed committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    a950653 View commit details
    Browse the repository at this point in the history
  5. add type annotations

    SalmonMode authored and blueyed committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    b1e1b73 View commit details
    Browse the repository at this point in the history
  6. fixup! cleaned up, DAMPified, and added tests to ensure fixtures only…

    … add ther finalizer to a dependee fixture once
    blueyed committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    4e07783 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Configuration menu
    Copy the full SHA
    9a87de6 View commit details
    Browse the repository at this point in the history