New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing: Node.reportinfo: might return py.path.local via fspath #6488

Merged

blueyed merged 1 commit into pytest-dev:master from blueyed:typing-fix-reportinfo

Jan 17, 2020

Contributor

blueyed commented Jan 17, 2020

No description provided.


          typing: Node.reportinfo: might return py.path.local via fspath

4a42dee

blueyed commented

View reviewed changes

src/_pytest/fixtures.py

@@ @@ -424,7 +424,7 @@ def module(self): @@
                       return self._pyfuncitem.getparent(_pytest.python.Module).obj
                   @scopeproperty()
-                  def fspath(self):
+                  def fspath(self) -> py.path.local:

Contributor Author

blueyed Jan 17, 2020

Note that mypy-diff (#6486) would complain here for this to be missing still (since mypy does not know about py.path.local).

nicoddemus approved these changes

View reviewed changes

blueyed merged commit e211d6f into pytest-dev:master

blueyed deleted the typing-fix-reportinfo branch

January 17, 2020 10:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment