[WIP] Avoid truncation when longer output, ref. #6267 #6462
Conversation
erheron
changed the title
|
As for a test I've noticed a change with https://github.com/pytest-dev/pytest/pull/6702/files#diff-14ad89cac128f1dd3aaa927c656035b3L992-R1025 in that regard. |
blueyed
added
topic: rewrite
This comment has been minimized.
This comment has been minimized.
src/_pytest/assertion/truncate.py
Outdated
| else: | ||
| msg += " ({} lines hidden".format(truncated_line_count) | ||
| if last_truncated: | ||
| msg += ",1 truncated)" |
There was a problem hiding this comment.
Looks like a missing space (after comma)?
There was a problem hiding this comment.
Yes, the space was missing. I've commited 2 changes, haven't squashed yet
(I've changed the base on my own now). |
Co-Authored-By: Daniel Hahler <github@thequod.de>
|
Hi @erheron, First of all we would like to thank you for your time and effort on working on this, the pytest team deeply appreciates it. We noticed it has been awhile since you have updated this PR, however. pytest is a high activity project, with many issues/PRs being opened daily, so it is hard for us maintainers to track which PRs are ready for merging, for review, or need more attention. So for those reasons we think it is best to close the PR for now, but with the only intention to cleanup our queue, it is by no means a rejection of your changes. We still encourage you to re-open this PR (it is just a click of a button away) when you are ready to get back to it. Again we appreciate your time for working on this, and hope you might get back to this at a later time! Cheers! |
|
Hi @nicoddemus. While working on this issue I got a feeling, that this is kind of minor change, and I'm not sure I want to re-open this. However, if someone else decides to work on this issue - please, feel free to use my code, if it would help You in any way! |
|
Sure @erheron! No worries, thanks a lot anyway, we appreciate it. 👍 |
Fixes #6267
Surely, because it's user-facing change, documentation/tests would need to change too, but now it's rather a proposal to mentioned issue.