Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Node._repr_failure_py: use abspath with changed cwd #6429

Closed
wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jan 9, 2020

Fixes #6428.

TODO:

  • test
  • changelog
  • use relative path to invocation dir

@lhupfeldt
Copy link

I think relative to invocation dir is important to keep the error messages short and readable.

@nicoddemus nicoddemus changed the title Node._repr_failure_py: use abspath with changed cwd WIP Node._repr_failure_py: use abspath with changed cwd Jan 13, 2020
@nicoddemus
Copy link
Member

Looks like a good start, thanks 👍

@lhupfeldt
Copy link

I think this should be merged now. Changing to use directory relative to invocation dir can be done later.

@blueyed
Copy link
Contributor Author

blueyed commented Jan 18, 2020

@lhupfeldt there are 2 other TODOs anyway, and I'd rather have it finished when/while doing the test for it, instead of adjusting the test later again.
If you'd like to help you can give it a try.

@blueyed blueyed changed the base branch from features to master February 12, 2020 15:08
@nicoddemus
Copy link
Member

Superseded by #7220

@nicoddemus nicoddemus closed this May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong path to test file when directory changed in fixture
3 participants