cache: NFPlugin: keep known nodeids #6004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caveat: does not forget about old nodeids Fixes pytest-dev#5206
blueyed
added
plugin: cache
blueyed
commented
Oct 19, 2019
| for item in items: | ||
| if item.nodeid not in self.cached_nodeids: | ||
| new_items[item.nodeid] = item | ||
| self.cached_nodeids.extend(new_items) |
There was a problem hiding this comment.
With regard to dropping isinstance here: see #3218 (comment)
Should either be kept if we have a test for this (testing/acceptance_test.py worked for me), or have a test to cover it if necessary.
This was referenced Oct 22, 2019
nicoddemus
approved these changes
Oct 22, 2019
| for item in items: | ||
| if item.nodeid not in self.cached_nodeids: | ||
| new_items[item.nodeid] = item | ||
| self.cached_nodeids.extend(new_items) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caveat: does not forget about old nodeids
Fixes #5206