setuponly: remove printing out/err from capman #5960
Conversation
This was added in pytest-dev@1a5e530b9. The test from there provides the same output with this fix, which makes sense, since it suspends capturing, reads the output and prints it after resuming capturing again. Therefore it can just leave it in the capture buffer in the first place. Fixes pytest-dev#5906
blueyed
force-pushed
the
setuponly-no-read_global_capture
branch
from
ed4a11d
to
fb44ee4
Compare
blueyed
changed the title
|
:S I was helping @yoavcaspi make their first contribution |
|
That was the wrong direction though. I've just created a PR already while looking into it. Can you approve it then maybe? |
|
next time help them in the right direction then! it's valuable to get people excited about contributing I don't think this is mergeable yet, there's no test for the bug or change |
Sure, but should I have then just posted the diff instead to the issue?
Ok, you can work with @yoavcaspi on it then maybe? |
This was added in 1a5e530b9.
The test from there provides the same output with this fix, which makes
sense, since it suspends capturing, reads the output and prints it after
resuming capturing again. Therefore it can just leave it in the capture
buffer in the first place.
Fixes #5906
/cc @kvas-it