Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings with attrs 19.2 and fix object assertions #5902

Merged
merged 2 commits into from Oct 6, 2019
Merged

Fix warnings with attrs 19.2 and fix object assertions #5902

merged 2 commits into from Oct 6, 2019

Commits on Oct 1, 2019

  1. Fix warnings with attrs 19.2 and fix object assertions 

    attrs 19.2 deprecated cmp in favor of the dataclass-ish eq/order duo.

This causes deprecation warnings that in turn break some of the cool new deep
object comparisons. Since we at attrs expected this to be a problem, it shipped
with helpers to write backward and forward compatible code.

This PR uses that and avoids changed to minimal versions.
    @hynek
    hynek committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    a79acf2 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2019

  1. Use ATTRS_EQ_FIELD for attrs 19.2 compat

    @asottile
    asottile committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    c58b0fb View commit details
    Browse the repository at this point in the history