Sort parametrize params to test_external_plugins_integrated #5563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might cause problems during collection with pytest-xdist; we didn't see any so far mostly by luck I think. Shame on me for letting that slip in.
nicoddemus
commented
Jul 5, 2019
tox.ini
Outdated
| @@ -131,6 +131,7 @@ filterwarnings = | |||
| ignore:yield tests are deprecated, and scheduled to be removed in pytest 4.0:pytest.RemovedInPytest4Warning | |||
| ignore:Metafunc.addcall is deprecated and scheduled to be removed in pytest 4.0:pytest.RemovedInPytest4Warning | |||
| ignore::pytest.RemovedInPytest4Warning | |||
| default:Using or importing the ABCs:DeprecationWarning | |||
There was a problem hiding this comment.
Unrelated to the main purpose of the PR, but Travis is now issuing this warning:
/home/travis/build/pytest-dev/pytest/.tox/py37-lsof-numpy-twisted-xdist/lib/python3.7/site-packages/unittest2/compatibility.py:143: in <module>
class ChainMap(collections.MutableMapping):
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
name = 'MutableMapping'
def __getattr__(name):
# For backwards compatibility, continue to make the collections ABCs
# through Python 3.6 available through the collections module.
# Note, no new collections ABCs were added in Python 3.7
if name in _collections_abc.__all__:
obj = getattr(_collections_abc, name)
import warnings
warnings.warn("Using or importing the ABCs from 'collections' instead "
"of from 'collections.abc' is deprecated, "
"and in 3.8 it will stop working",
> DeprecationWarning, stacklevel=2)
E DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
There was a problem hiding this comment.
I think this is redundant with #5565, right? In which case I'd rather wait for that rather than suppress the warning, since it could indicate a real problem somewhere else!
There was a problem hiding this comment.
Changed this to be specific to unittest2 now, given that we won't be actually dropping unittest2 until 6.0.
There was a problem hiding this comment.
@Zac-HD can you please approve if this looks good to you now? Thanks! 🙇
Codecov Report
@@ Coverage Diff @@
## master #5563 +/- ##
==========================================
+ Coverage 93.83% 96.11% +2.27%
==========================================
Files 117 117
Lines 25713 25713
Branches 2493 2493
==========================================
+ Hits 24128 24714 +586
+ Misses 1256 695 -561
+ Partials 329 304 -25
Continue to review full report at Codecov.
|
This is being raised by `unittest2.compatibility`: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might cause problems during collection with pytest-xdist; we
didn't see any so far mostly by luck I think.
Shame on me for letting that slip in. 😓