Remove deprecated features #5529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is no longer deprecated, but part of the normal code for 'config'
Those are not really deprecated anymore and are part of the normal code for config
This is no longer a deprecation so it makes sense to move it to the place where it is needed instead of leaving it in deprecated.py
Codecov Report
@@ Coverage Diff @@
## features #5529 +/- ##
============================================
- Coverage 96.08% 96.04% -0.05%
============================================
Files 117 117
Lines 25695 25533 -162
Branches 2493 2488 -5
============================================
- Hits 24690 24522 -168
- Misses 701 706 +5
- Partials 304 305 +1
Continue to review full report at Codecov.
|
…ments As suggested during review
|
Any more reviewers? |
|
@RonnyPfannschmidt can you please approve if it looks OK to you? |
Merged
asottile
approved these changes
Jul 9, 2019
|
Thanks! |
bluetech
reviewed
Jul 10, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5180
This is quite a large diff, but can be reviewed on a commit-by-commit basis.
While at it, I noticed a few features deprecated in 3.X and turned into errors still left constants in
deprecated.pyand tests indeprecated_test.py. I've moved the constants (when applicable, sometimes I just inlined them) and tests to the their now appropriate location.