Apply workaround for multiple short options for Python <= 3.8 #5526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully by Python 3.9 this will be fixed upstream, if not we will need to bump the version again. Fix pytest-dev#5523
nicoddemus
force-pushed
the
cmdline-shortopt
branch
from
52ba0b5
to
9021194
Compare
|
Just realized this, why are we not testing Python 3.8? 🤔 |
Codecov Report
@@ Coverage Diff @@
## master #5526 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 117 117
Lines 25695 25695
Branches 2493 2493
=======================================
Hits 24696 24696
Misses 695 695
Partials 304 304
Continue to review full report at Codecov.
|
|
Oh we run py38 as a cron job... not sure it is effective, hardly ever looks at the cron jobs, I'm afraid. Made running py38 part of the standard jobs again, now that we have significantly reduced the build matrix on |
Zac-HD
approved these changes
Jun 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully by Python 3.9 this will be fixed upstream, if not we will
need to bump the version again.
Fix #5523