Fix dependencies on 'terminal' plugin

[ikonst]

Fix #5139

[codecov]

Codecov Report

Merging #5138 into master will increase coverage by <.01%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master    #5138      +/-   ##
==========================================
+ Coverage   96.06%   96.06%   +<.01%     
==========================================
  Files         114      114              
  Lines       25784    25790       +6     
  Branches     2550     2550              
==========================================
+ Hits        24770    24776       +6     
  Misses        704      704              
  Partials      310      310

Impacted Files	Coverage Δ
src/_pytest/reports.py	95% <ø> (ø)	⬆️
src/_pytest/config/__init__.py	94.4% <100%> (ø)	⬆️
testing/test_config.py	99.49% <100%> (ø)	⬆️
src/_pytest/nodes.py	95.58% <66.66%> (ø)	⬆️
src/_pytest/python.py	93.3% <66.66%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 008d043...d67d68f. Read the comment docs.

[blueyed]

Thanks for working on this!

I wonder what @RonnyPfannschmidt has to say about the terminal plugin options being coupled like that - shouldn't only the terminal part/plugin itself know about it in the best case?

[ikonst]

I agree this coupling is not optimal. I only corrected the code with the assumption that this coupling is a necessary evil for now.

[blueyed]

@ikonst
That is good, yeah - just wondered myself how to improve this in the future.

[blueyed]

Since this is green on CI now, please squash and force-push it (it does not need 7 commits, and we have the squash-merge button disabled here).

[blueyed]

Thank you!