Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show testpaths option in the header if it has been used for collection #4876

Merged

Conversation

nicoddemus
Copy link
Member

Fix #4875

@nicoddemus nicoddemus requested a review from blueyed March 2, 2019 14:20
Copy link
Contributor

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the inverted logic in the changelog this looks good.

changelog/4875.feature.rst Outdated Show resolved Hide resolved
@nicoddemus nicoddemus force-pushed the show-testpaths-in-header-4875 branch from 53a3d3e to b010f07 Compare March 2, 2019 14:37
@codecov
Copy link

codecov bot commented Mar 2, 2019

Codecov Report

Merging #4876 into features will decrease coverage by 3.29%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           features    #4876     +/-   ##
===========================================
- Coverage     95.76%   92.47%   -3.3%     
===========================================
  Files           113      113             
  Lines         25744    25239    -505     
  Branches       2508     2500      -8     
===========================================
- Hits          24655    23339   -1316     
- Misses          773     1497    +724     
- Partials        316      403     +87
Flag Coverage Δ
#linux 92.32% <100%> (-3.27%) ⬇️
#osx ?
#windows 91.3% <100%> (-2.3%) ⬇️
Impacted Files Coverage Δ
testing/test_session.py 96.68% <ø> (-0.03%) ⬇️
src/_pytest/terminal.py 91.47% <100%> (-0.41%) ⬇️
testing/test_config.py 99.46% <100%> (-0.02%) ⬇️
testing/test_terminal.py 99.24% <100%> (-0.57%) ⬇️
src/_pytest/_code/_py2traceback.py 20% <0%> (-71.12%) ⬇️
testing/test_pdb.py 48.75% <0%> (-50.37%) ⬇️
testing/python/approx.py 80.45% <0%> (-19.18%) ⬇️
src/_pytest/unittest.py 75.13% <0%> (-19.14%) ⬇️
src/_pytest/compat.py 78.89% <0%> (-17.65%) ⬇️
src/_pytest/debugging.py 63.58% <0%> (-16.53%) ⬇️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f97e4...0deb7b1. Read the comment docs.

@nicoddemus
Copy link
Member Author

nicoddemus commented Mar 2, 2019

Thanks for the quick review.

I've pushed another commit also removing inifile: from the header if we don't have an inifile, I think it makes the output leaner.

What do you think?

@@ -1199,15 +1219,6 @@ def test_summary_stats(exp_line, exp_color, stats_arg):
assert color == exp_color


def test_no_trailing_whitespace_after_inifile_word(testdir):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is now unnecessary, test_header already covers this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@nicoddemus nicoddemus force-pushed the show-testpaths-in-header-4875 branch from b010f07 to 0deb7b1 Compare March 2, 2019 14:45
@nicoddemus nicoddemus merged commit 35c85f0 into pytest-dev:features Mar 2, 2019
@nicoddemus nicoddemus deleted the show-testpaths-in-header-4875 branch March 2, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants